shield-update-fetcher #3657
Merged
shield-update-fetcher #3657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # telegram/ext/_application.py
harshil21
reviewed
Apr 24, 2023
Member
harshil21
left a comment
There was a problem hiding this comment.
Nice. Though can't we just use asyncio.shield() in app.start()?
Member
Author
That is actually way better! Don't know why I didn't think of it :D It works in a manual test. Let's see if the CI is happy as well - I'm not on a linux machine rn … |
This reverts commit 9cbb070.
Member
Author
|
So apparently |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://t.me/pythontelegrambotgroup/670240?thread=670177 for a reference.
I'll have to check if I can write a unit test for this special case …
Checklist for PRs
[ ] Added.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)[ ] Added myself alphabetically toAUTHORS.rst(optional)[ ] Added new classes & modules to the docs and all suitable__all__s