Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

Replacement for #3420

@Bibo-Joshi Bibo-Joshi added the ⚙️ tests affected functionality: tests label Feb 11, 2023
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work cleaning up the tests structure. Maybe worth doing these as well:

  • Adding the ext, inline, passport folders in the tests so we can shift related test files in there. I believe they can have their own conftests as well if that helps in better organizing it

@harshil21 harshil21 added this to the v20.2 milestone Feb 12, 2023
@Bibo-Joshi Bibo-Joshi removed this from the v20.2 milestone Feb 13, 2023
@Bibo-Joshi
Copy link
Member Author

  • Adding the ext, inline, passport folders in the tests so we can shift related test files in there. I believe they can have their own conftests as well if that helps in better organizing it

I guess then it would make sense to mimic the whole directory structure of telegram. I'll have to look more closely into how pytest discovers tests. should have time on the weekend

@Bibo-Joshi Bibo-Joshi changed the title Move things from conftest to tests/auxil Tidy up tests directory Feb 18, 2023
@Bibo-Joshi Bibo-Joshi requested a review from harshil21 February 20, 2023 19:01
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi Bibo-Joshi merged commit 22d0dd1 into master Feb 22, 2023
@Bibo-Joshi Bibo-Joshi deleted the tidy-up-conftest branch February 22, 2023 19:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2023
@harshil21 harshil21 added this to the v20.2 milestone Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ tests affected functionality: tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants