-
Notifications
You must be signed in to change notification settings - Fork 6k
Handle symlinks in was_called_by
#3552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
|
After a bit of trial and error, I figured out that the windows test fail due to the usage of This may give false warnings in rare cases where The benefit of this change is that |
|
Good work! It looks good to me. |
Poolitzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a small change, such a big test :D
Code looks good!
Supersedes #3538. Closes #3536
Checklist for PRs
[x] Added.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)Added new classes & modules to the docs and all suitable__all__s