Add images and videos to docs #3535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4b1a99 to
5abd254
Compare
Bibo-Joshi
approved these changes
Feb 6, 2023
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Nice idea with the automated color scheme preference 👍
lemontree210
requested changes
Feb 6, 2023
Member
lemontree210
left a comment
There was a problem hiding this comment.
The docs are getting prettier still :)
- Why is this PR against
master? (Just checking) - A clickable image opening in a new tab (leading either to the larger image or even the section of Telegram docs) would be a nice-to-have, but that would mean using that raw html thing you did with the video
Co-authored-by: Dmitry Kolomatskiy <58207913+lemontree210@users.noreply.github.com>
Member
|
Can the DS issue be resolved or is that complaint unreasonable? |
clot27
reviewed
Feb 7, 2023
Member
Author
|
I ignored the Deepsource error within deepsource itself, so hopefully it won't trigger again |
lemontree210
approved these changes
Feb 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some images and a video to the docs. This was taken from https://core.telegram.org/bots/features.
For the dark mode version of the images, I simply used a
invert()on them. If we decide to add more pictures or videos to other places in the docs, we could think about a pure dark and light mode version of eachBuild should be up at: https:https://docs.python-telegram-bot.org/en/doc-pictures/
Checklist for PRs
Added.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)Created new or adapted existing unit testsAdded myself alphabetically toAUTHORS.rst(optional)Added new classes & modules to the docs and all suitable__all__s