Skip to content

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Nov 22, 2022

Closes #3379

  • Attributes which are removed will automatically go to the object's api_kwargs.
  • Attributes which are new to the class won't be available in the unpickled version

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@harshil21 harshil21 added this to the v20.0a6 milestone Nov 22, 2022
@harshil21 harshil21 changed the title Fix unpickling of classes with removed attributes Fix unpickling of classes with new/removed attributes Nov 23, 2022
@Bibo-Joshi Bibo-Joshi merged commit 1724212 into master Nov 24, 2022
@Bibo-Joshi Bibo-Joshi deleted the pickle-api-kwargs branch November 24, 2022 11:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 bug pr description: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] PicklePersistence: AttributeError: 'Chat' object has no attribute 'all_members_are_administrators'

3 participants