Skip to content

Fix Deepsource issues #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 1 commit into from
Nov 11, 2022
Merged

Fix Deepsource issues #3357

Bibo-Joshi merged 1 commit into from
Nov 11, 2022

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Nov 11, 2022

Closes #3285

@harshil21 harshil21 added misc 🛠 code-quality change type: code-quality labels Nov 11, 2022
@harshil21 harshil21 added this to the v20.0a5 milestone Nov 11, 2022
harshil21
harshil21 commented Nov 11, 2022
View reviewed changes
Bibo-Joshi
Bibo-Joshi reviewed Nov 11, 2022
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest looks good to me :) Do you know if these are all things that DS is currently complaining about? A subset would also already be great 😄

@harshil21
Copy link
Member Author

harshil21 commented Nov 11, 2022 •
edited
Loading

Do you know if these are all things that DS is currently complaining about?

Their UI/UX is confusing, seeing all "issues" in the repo has like only 6. But if I go to the history tab, I can find more things it complains about, which this PR fixes anyway.

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Nov 11, 2022

@harshil21 Yeah, the UI is a bitt messed up. And I really do hope that they do something about https://discuss.deepsource.io/t/improve-granular-setting-possibility-to-pin-a-deepsource-version/472 … but okay, if those are all the issues that you could find, I'm good with closing #3285 though this PR 👌🏻
let's try to remember to merge master into the pending PRs to see if any new issues come up 😅

@Bibo-Joshi Bibo-Joshi merged commit e1d5617 into master Nov 11, 2022
@Bibo-Joshi Bibo-Joshi deleted the fix-deepsource branch November 11, 2022 17:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi left review comments

Assignees

No one assigned

Labels

🛠 code-quality change type: code-quality

Projects

None yet

Milestone

v20.0a5

Development

Successfully merging this pull request may close these issues.

Address DeepSource issues

3 participants

@harshil21 @Bibo-Joshi