Skip to content

Ensure that the test_difference_optionals actually does something #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 1 commit into from
Nov 8, 2022
Merged

Ensure that the test_difference_optionals actually does something #3352

Bibo-Joshi merged 1 commit into from
Nov 8, 2022

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Nov 8, 2022

No description provided.

@Bibo-Joshi Bibo-Joshi added the ⚙️ tests affected functionality: tests label Nov 8, 2022
@Bibo-Joshi Bibo-Joshi requested a review from harshil21 November 8, 2022 14:41
harshil21
harshil21 approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, works now

@harshil21 harshil21 added this to the v20.0a5 milestone Nov 8, 2022
@Bibo-Joshi Bibo-Joshi merged commit 8dead11 into master Nov 8, 2022
@Bibo-Joshi Bibo-Joshi deleted the fix-test-chamberberupdated.difference branch November 8, 2022 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@harshil21 harshil21 harshil21 approved these changes

Assignees

No one assigned

Labels

⚙️ tests affected functionality: tests

Projects

None yet

Milestone

v20.0a5

Development

Successfully merging this pull request may close these issues.

3 participants

@Bibo-Joshi @harshil21