Skip to content

Add a test for MessageAttachmentType #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 2 commits into from
Nov 6, 2022
Merged

Add a test for MessageAttachmentType #3335

Bibo-Joshi merged 2 commits into from
Nov 6, 2022

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Nov 5, 2022

Simply adds a test to make sure all constants in MessageAttachmentType are in MessageType

@harshil21 harshil21 added the ⚙️ tests affected functionality: tests label Nov 5, 2022
@harshil21 harshil21 added this to the v20.0b0 milestone Nov 5, 2022
@harshil21 harshil21 added the 📋 pending-review work status: pending-review label Nov 5, 2022
Poolitzer
Poolitzer approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshil21 harshil21 removed the 📋 pending-review work status: pending-review label Nov 6, 2022
@Bibo-Joshi Bibo-Joshi merged commit 834568d into master Nov 6, 2022
@Bibo-Joshi Bibo-Joshi deleted the add-const-test branch November 6, 2022 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Poolitzer Poolitzer Poolitzer approved these changes

Assignees

No one assigned

Labels

⚙️ tests affected functionality: tests

Projects

None yet

Milestone

v20.0a5

Development

Successfully merging this pull request may close these issues.

4 participants

@harshil21 @Poolitzer @Bibo-Joshi