Skip to content

Add mention_XXX to Chat class #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 6 commits into from
Oct 31, 2022
Merged

Add mention_XXX to Chat class #3308

Bibo-Joshi merged 6 commits into from
Oct 31, 2022

Conversation

@miles170
Copy link
Contributor

@miles170 miles170 commented Oct 25, 2022

Add mention_markdown and mention_markdown_v2 and mention_html to Chat class.

Closes #3216.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

Poolitzer
Poolitzer requested changes Oct 26, 2022
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, quick and well made PR, did not spot a logic fault! Just nitpicking at words, as I usually do.

harshil21
harshil21 reviewed Oct 26, 2022
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and swift work. I think we should also add a Raises: block to each of the methods describing when the method fails

@harshil21 harshil21 added enhancement hacktoberfest-accepted other: hacktoberfest-accepted labels Oct 26, 2022
@harshil21 harshil21 added this to the v20.0b1 milestone Oct 26, 2022
Poolitzer
Poolitzer approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi Bibo-Joshi merged commit 25dc87a into python-telegram-bot:master Oct 31, 2022
@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Oct 31, 2022

Thank you very much for your contribution @miles170 :)

@miles170 miles170 deleted the issues-3216-add-mention-xxx-to-chat branch October 31, 2022 08:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi left review comments

@Poolitzer Poolitzer Poolitzer approved these changes

@harshil21 harshil21 harshil21 approved these changes

Assignees

No one assigned

Labels

🔌 enhancement pr description: enhancement hacktoberfest-accepted other: hacktoberfest-accepted

Projects

None yet

Milestone

v20.0a5

Development

Successfully merging this pull request may close these issues.

[Suggestion] Add mention_XXX to Chat class

4 participants

@miles170 @Bibo-Joshi @Poolitzer @harshil21