Skip to content

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Oct 16, 2022

Adds 2 new constants to FileSizeLimit if you're running in local mode.

Didn't go with math.inf for FILESIZE_DOWNLOAD_LOCAL since that's a float which can't be converted to int. So went with sys.maxsize

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added new classes & modules to the docs and all suitable __all__ s

@harshil21 harshil21 added this to the v20.0a5 milestone Oct 16, 2022
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Bibo-Joshi Bibo-Joshi merged commit eb818da into master Oct 17, 2022
@Bibo-Joshi Bibo-Joshi deleted the more-consts branch October 17, 2022 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 enhancement pr description: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants