Optional 3rd Party dependencies #3267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshil21
reviewed
Oct 1, 2022
# Conflicts: # telegram/ext/_extbot.py # telegram/ext/_jobqueue.py # tests/test_callbackdatacache.py
# Conflicts: # telegram/ext/_jobqueue.py
Poolitzer
approved these changes
Oct 8, 2022
Member
Poolitzer
left a comment
There was a problem hiding this comment.
Code changes look good to me.
I just realized we could make an optional version with 0 dependencies if we remove the httpx implementation for this version, allowing people to use their own httpx version. Might be nice so they can do whatever they want with no version conflicts.
Member
|
@Poolitzer at that point there won't really be any difference between PTB and ptb-raw, I strongly think httpx should not be optional. I think having aps optional will also be quite annoying to most |
Member
|
@harshil21 yes, I think people will have to change their setup a lot. |
harshil21
reviewed
Oct 9, 2022
Member
Author
|
Two things that I forgot so far:
|
# Conflicts: # .github/workflows/test.yml
harshil21
reviewed
Oct 30, 2022
# Conflicts: # tests/test_bot.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes all 3rd party dependencies optional, i.e. addresses https://github.com/python-telegram-bot/python-telegram-bot/projects/7#card-77767364.
Currently based against the
read-only-cdcbranch, b/c that must be merged first and the diff is better readible this way.Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)Added myself alphabetically toAUTHORS.rst(optional)Added new classes & modules to the docs and all suitable__all__s