Skip to content

Fix mention_markdown for Markdown V1 #3155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 3 commits into from
Jul 17, 2022
Merged

Fix mention_markdown for Markdown V1 #3155

Bibo-Joshi merged 3 commits into from
Jul 17, 2022

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Jul 13, 2022

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

Closes #3142

@harshil21 harshil21 added this to the v20.0a3 milestone Jul 13, 2022
@harshil21 harshil21 added the 📋 pending-review work status: pending-review label Jul 13, 2022
Bibo-Joshi
Bibo-Joshi reviewed Jul 13, 2022
View reviewed changes
@Bibo-Joshi Bibo-Joshi mentioned this pull request Jul 14, 2022
Closed
why-not-try-calmer
why-not-try-calmer approved these changes Jul 15, 2022
View reviewed changes
Copy link

@why-not-try-calmer why-not-try-calmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks!

@Bibo-Joshi Bibo-Joshi merged commit 55d66a9 into master Jul 17, 2022
@Bibo-Joshi Bibo-Joshi deleted the fix_escape_mk1 branch July 17, 2022 11:07
@harshil21 harshil21 removed the 📋 pending-review work status: pending-review label Jul 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi left review comments

+1 more reviewer

@why-not-try-calmer why-not-try-calmer why-not-try-calmer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🔌 bug pr description: bug

Projects

None yet

Milestone

v20.0a3

Development

Successfully merging this pull request may close these issues.

[BUG] Invalid MarkdownV1 parsing

4 participants

@harshil21 @why-not-try-calmer @Bibo-Joshi