Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@Bibo-Joshi Bibo-Joshi added this to the v20.0a3 milestone Jul 8, 2022
@Bibo-Joshi Bibo-Joshi requested a review from harshil21 July 8, 2022 22:17
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't I point this out in some PR? Maybe the change was never implemented or was lost in a rebase.

Edit: nvm that was Bot.close() (#3035 (comment))

@Bibo-Joshi Bibo-Joshi merged commit 142e3c0 into master Jul 10, 2022
@Bibo-Joshi Bibo-Joshi deleted the log-out-api-kwargs branch July 10, 2022 13:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 bug pr description: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants