Skip to content

Update default values for concurrent_updates and connection_pool_size #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 2 commits into from
Jun 29, 2022
Merged

Update default values for concurrent_updates and connection_pool_size #3127

Bibo-Joshi merged 2 commits into from
Jun 29, 2022

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Jun 28, 2022

closes #3125

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@Bibo-Joshi Bibo-Joshi added ⚙️ documentation affected functionality: documentation 🛠 refactor change type: refactor labels Jun 28, 2022
@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer June 28, 2022 19:31
Poolitzer
Poolitzer approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@Bibo-Joshi Bibo-Joshi merged commit f1d0339 into master Jun 29, 2022
@Bibo-Joshi Bibo-Joshi deleted the pool-size branch June 29, 2022 19:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
@harshil21 harshil21 added this to the v20.0a3 milestone Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Poolitzer Poolitzer Poolitzer approved these changes

Assignees

No one assigned

Labels

⚙️ documentation affected functionality: documentation 🛠 refactor change type: refactor

Projects

None yet

Milestone

v20.0a3

Development

Successfully merging this pull request may close these issues.

Adjust defaults for concurrent_updates and conenction_pool_size

4 participants

@Bibo-Joshi @Poolitzer @harshil21