-
Notifications
You must be signed in to change notification settings - Fork 6k
Drop pre-commit dependencies from reqs-dev #3120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)
|
The workflow also notified on Additionally, I would probably add a line in |
harshil21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but wouldn't this just make dependabot not notify us of any new releases for the deleted dev-reqs? maybe a better option is to ignore minor and patch versions for those?
we can also change the dependabot separator to "-" to conform to our style more.
fwiw, I'm still for automating updating pre-commit's additional_dependencies on dependabot PR's using a custom .yml script, but I don't know if/how that's possible
|
@harshil21 It should be very easy if we cant tell dependabot about it to write our own for that actually. |
|
@Poolitzer yeah we can't even tell |
Thanks for the catch! Had overlooked that and will revert acoordingly
Jup, good idea 👍
pre-commit.ci takes care of that - see #3085
With the slash, Pycharm automatically groups the branches in a directory style. I like that very much tbh, but in the end it's just a ide-specific gimmick. I'm fine with either way
that would indeed be nice! I found dependabot/dependabot-core#2040 on this - FYI. |
This reverts commit 4571f87.
# Conflicts: # requirements-dev.txt
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Just a suggestion.
Pros:
reqs-devand.pre-commitin syncpre-commitstill works as expectedCons:
blackandisortdon't have the directly availbale viapip install -r reqs-dev.txt. Not sure how many people actually do that though, plus which of them are not familiar enough with our setup to just get the version from the pre-commit config …