Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

Mostly as discussed in the dev chat. Allows users to run custom startup logic.

Also orders AppBuilder.__slots__ alphabetically

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes) Only changed classes that already have the "new in v20" directive"
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@Bibo-Joshi Bibo-Joshi added this to the v20.0a1 milestone Jun 3, 2022
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi Bibo-Joshi merged commit 63104ac into master Jun 8, 2022
@Bibo-Joshi Bibo-Joshi deleted the custom-init-callback branch June 8, 2022 05:44
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 enhancement pr description: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants