Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented May 30, 2022

There has already been some feed back on #3037 in #3054, so if we do an a1 release soonish, then IMO it's probably good to make the json logic customizable already.

This PR does the minimal effort solution for that, i.e. make the payload-parsing method of BaseRequest public. IMO making the raw parameters available (instead of the to_dict() versions) can be done at a later stage if there is a request for it. For now the use case should be relatively small as TGObject classes are no dataclasses yet.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

closes #3054

@Bibo-Joshi Bibo-Joshi added this to the v20.0a1 milestone May 30, 2022
@Bibo-Joshi Bibo-Joshi merged commit 6786969 into master Jun 1, 2022
@Bibo-Joshi Bibo-Joshi deleted the customize-json branch June 1, 2022 19:26
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 enhancement pr description: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Maintain ujson support.

3 participants