Aligned JobQueue.run_daily days parameter with cron weekdays notation. #3046
+43
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
days parameter with cron weekdays notation (#3038)
Bibo-Joshi
requested changes
May 19, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the nice PR! It looks good overall 👍 The comments I left below are mostly just small stuff :)
Bibo-Joshi
requested changes
May 20, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
just one nitpick :) please also merge the master branch into yours - we changed the pre-commit settings a bit so we should make sure that your branch passes the updated version as well
Bibo-Joshi
approved these changes
May 24, 2022
Poolitzer
reviewed
May 24, 2022
Comment on lines
+456
to
+460
| warn( | ||
| "Prior to v20.0 the `days` parameter was not aligned to that of cron's weekday scheme." | ||
| "We recommend double checking if the passed value is correct.", | ||
| stacklevel=2, | ||
| ) |
Member
There was a problem hiding this comment.
What about a comment here, reminding us that we remove this in the next major version?
Contributor
Author
There was a problem hiding this comment.
is this enough?
# TODO: After v20.0, we should remove the this warning.
Member
There was a problem hiding this comment.
should be enough IMO, yes :)
Member
|
Thank you for the contribution! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included in the PR for issue #3038 - closes #3038:
JobQueue.run_dailythat thedaysparameter range 0-6 is now sunday-saturday.Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)pre-commitchecks out