enforce v20 in examples #3036
Merged
enforce v20 in examples #3036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bibo-Joshi
reviewed
May 15, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
- this doesn't address the problem with
ContextTypes.DEFAULT_TYPE- for that we have to check that we have__version_info__ > (20, 0, 0, 'alpha', 0)if__version_info__is available - I think it would be good to explicitly tell the user which version they are using - something along the lines
f'You are using version {__version__}' - Can we add a header to the examples readme along the lines "The examples in the directory are subject to changes and may not work on the PTB version that you are using. You can find the examples compatible with a specific ptb version at
https://…/tree/<vX.Y>/examples"?
Bibo-Joshi
reviewed
May 15, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
With version-checking in place, I'd be okay with simply removing the example-warning workflow. One thing less to worry about while developing.
Bibo-Joshi
approved these changes
May 15, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
I'll merge once the tests are done :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforces correct version in examples so people don't get confused.