Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

closes #3022

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@Bibo-Joshi Bibo-Joshi added this to the v20.0a1 milestone May 14, 2022
@harshil21 harshil21 added 🛠 refactor change type: refactor 🛠 breaking change type: breaking labels May 14, 2022
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Bibo-Joshi Bibo-Joshi merged commit c104165 into master May 18, 2022
@Bibo-Joshi Bibo-Joshi deleted the _id_attrs branch May 18, 2022 05:48
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🛠 breaking change type: breaking 🛠 refactor change type: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double check the API 6.0 update if _id_attrs should have been updated

3 participants