Skip to content

Conversation

@Poolitzer
Copy link
Member

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

I found this while adapting the V13 tests. According to our type hinting this should be more correct, lets see if the CI agrees.

@Poolitzer Poolitzer changed the title Fix: Change string to bool Fix: Small test fixes May 12, 2022
@Poolitzer Poolitzer changed the title Fix: Small test fixes Fix: Change string to bool May 12, 2022
@Poolitzer Poolitzer changed the title Fix: Change string to bool Fix: Change Test parameter string to bool May 12, 2022
@Poolitzer Poolitzer changed the title Fix: Change Test parameter string to bool Small test improvements May 12, 2022
@harshil21 harshil21 added this to the v20.0a1 milestone May 12, 2022
@harshil21 harshil21 added the ⚙️ tests affected functionality: tests label May 12, 2022
@Bibo-Joshi Bibo-Joshi merged commit d6e95f1 into master Jun 9, 2022
@Bibo-Joshi Bibo-Joshi deleted the IKB-test-fix branch June 9, 2022 15:07
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ tests affected functionality: tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants