Skip to content

WIP: Change types.SLT to use Collection #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 3 commits into from
May 13, 2022
Merged

WIP: Change types.SLT to use Collection #3025

Bibo-Joshi merged 3 commits into from
May 13, 2022

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented May 11, 2022

Closes #2891

Documentation not yet updated

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@Bibo-Joshi Bibo-Joshi added the ⚙️ type-hinting affected functionality: type-hinting label May 11, 2022
@harshil21 harshil21 added this to the v20.0a1 milestone May 12, 2022
@Bibo-Joshi Bibo-Joshi marked this pull request as ready for review May 12, 2022 20:03
@Bibo-Joshi Bibo-Joshi merged commit f792102 into master May 13, 2022
@Bibo-Joshi Bibo-Joshi deleted the improve-slt branch May 13, 2022 14:41
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@harshil21 harshil21 harshil21 approved these changes

Assignees

No one assigned

Labels

⚙️ type-hinting affected functionality: type-hinting

Projects

None yet

Milestone

v20.0a1

Development

Successfully merging this pull request may close these issues.

Improvements of types.SLT

3 participants

@Bibo-Joshi @harshil21