Skip to content

Rename Handler to BaseHandler #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 1 commit into from
May 12, 2022
Merged

Rename Handler to BaseHandler #3019

Bibo-Joshi merged 1 commit into from
May 12, 2022

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented May 9, 2022 •
edited by harshil21
Loading

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

TODO:

  • Update wiki after release of v20.0a1
  • Update transition script for this

harshil21
harshil21 reviewed May 9, 2022
View reviewed changes
@harshil21 harshil21 added 🛠 refactor change type: refactor 🛠 breaking change type: breaking labels May 9, 2022
@harshil21 harshil21 added this to the v20.0a1 milestone May 9, 2022
@Bibo-Joshi Bibo-Joshi merged commit 65bbea7 into master May 12, 2022
@Bibo-Joshi Bibo-Joshi deleted the rename-handler branch May 12, 2022 16:18
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@harshil21 harshil21 harshil21 left review comments

Assignees

No one assigned

Labels

🛠 breaking change type: breaking 🛠 refactor change type: refactor

Projects

None yet

Milestone

v20.0a1

Development

Successfully merging this pull request may close these issues.

3 participants

@Bibo-Joshi @harshil21