-
Notifications
You must be signed in to change notification settings - Fork 6k
to_true shortcut for ChatPermissions #2948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just had a quick glance and let some tipicking. Still, I'd like to come back to this only after we've merged asyncio ;)
Also now the _id_attrs are updated.
also renamed all_true to all_permissions. And fixed the docstring of it
792b09b to
15ec7dc
Compare
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @harshil21 do you have any comments left? If not, you can go ahead and merge IMO
harshil21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)If the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrsand corresponding documentation__init__accepts**_kwargsAdded new shortcuts:
Chat&Userfor all methods that acceptchat/user_idMessagefor all methods that acceptchat_idandmessage_idMessageshortcuts: Addedquoteargument if methods acceptsreply_to_message_idCallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
telegram.constantsand shortcuts to them as class variablesREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSIONtg.ext.Botfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.MessageThis was a spontaneous idea and quickly done by me to avoid other work. No proper issue to close here.