Skip to content

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Feb 1, 2022

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts **_kwargs
  • Added new shortcuts:

    • In Chat & User for all methods that accept chat/user_id
    • In Message for all methods that accept chat_id and message_id
    • For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION
    • Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

Used the potato doge webm sticker from: https://t.me/TrendingStickers/1978

Note about a sticker test:
Didn't implement a test_bot_methods_3_webm since the webm file is too large to be a thumb... can anyone compress it?

Edit:
Skipped that test, see that test for the reason.

@harshil21 harshil21 added the ⚙️ bot-api affected functionality: bot-api label Feb 1, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

@harshil21 harshil21 added the 📋 pending-review work status: pending-review label Feb 1, 2022
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@harshil21 harshil21 added this to the 13.11 milestone Feb 1, 2022
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast PR! Left a few nitpicks.
One can download the thumb of a sticker set - maybe that suffices for the _3 test?

import asyncio

from telegram import Bot


async def main():
    async with Bot(TOKEN') as bot:
        sticker_set = await bot.get_sticker_set('Potato')
        await (await sticker_set.thumb.get_file()).download('video_thumb.webm')

if __name__ == '__main__':
    asyncio.run(main())

@harshil21 harshil21 removed the 📋 pending-review work status: pending-review label Feb 1, 2022
@harshil21 harshil21 added the 📋 pending-merge work status: pending-merge label Feb 1, 2022
@Bibo-Joshi Bibo-Joshi merged commit a35ecf4 into master Feb 2, 2022
@Bibo-Joshi Bibo-Joshi deleted the api-5.7 branch February 2, 2022 20:05
@harshil21 harshil21 removed the 📋 pending-merge work status: pending-merge label Feb 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ bot-api affected functionality: bot-api

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants