-
Notifications
You must be signed in to change notification settings - Fork 6k
API 5.7 #2881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API 5.7 #2881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)
Poolitzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fast PR! Left a few nitpicks.
One can download the thumb of a sticker set - maybe that suffices for the _3 test?
import asyncio
from telegram import Bot
async def main():
async with Bot(TOKEN') as bot:
sticker_set = await bot.get_sticker_set('Potato')
await (await sticker_set.thumb.get_file()).download('video_thumb.webm')
if __name__ == '__main__':
asyncio.run(main())
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)If the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrsand corresponding documentation__init__accepts**_kwargsAdded new shortcuts:
Chat&Userfor all methods that acceptchat/user_idMessagefor all methods that acceptchat_idandmessage_idMessageshortcuts: Addedquoteargument if methods acceptsreply_to_message_idCallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
telegram.constantsand shortcuts to them as class variablesREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSIONtg.ext.Botfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.MessageUsed the
potato dogewebm sticker from: https://t.me/TrendingStickers/1978Note about a sticker test:
Didn't implement a
test_bot_methods_3_webmsince the webm file is too large to be a thumb... can anyone compress it?Edit:
Skipped that test, see that test for the reason.