Skip to content

exact description of which command is not valid #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kilomeow wants to merge 2 commits into from
Closed

exact description of which command is not valid #2707

kilomeow wants to merge 2 commits into from

Conversation

@kilomeow
Copy link

@kilomeow kilomeow commented Oct 6, 2021

ValueError message contains wrong command

@kilomeow
exact description of which command is not valid
ea1a5c9 
ValueError message contains wrong command
@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Oct 6, 2021 •
edited
Loading

Hi, thanks for the catch! It seems that this test

python-telegram-bot/tests/test_commandhandler.py

Lines 189 to 196 in bc7c422

@pytest.mark.parametrize(
'cmd',
['way_too_longcommand1234567yes_way_toooooooLong', 'ïñválídletters', 'invalid #&* chars'],
ids=['too long', 'invalid letter', 'invalid characters'],
)
def test_invalid_commands(self, cmd):
with pytest.raises(ValueError, match='not a valid bot command'):
CommandHandler(cmd, self.callback_basic)

doesn't check the error message carefully enough. Could you maybe change the match argument of pytest.raises to match=f'`{cmd}` is not a valid bot command' so that we improve this?

harshil21
harshil21 reviewed Oct 6, 2021
View reviewed changes
@harshil21 harshil21 added this to the v14 milestone Oct 7, 2021
@harshil21 harshil21 added the 📋 pending-reply work status: pending-reply label Oct 8, 2021
@kilomeow @harshil21
Update telegram/ext/commandhandler.py
979aad0 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Oct 19, 2021

Thanks for the update! However, the unit test will have to be adapted before we can merge :)

@Bibo-Joshi Bibo-Joshi mentioned this pull request Dec 31, 2021
Merged
3 tasks
@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Dec 31, 2021

closing due to inactivity & in favor of #2837

@Bibo-Joshi Bibo-Joshi closed this Dec 31, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@harshil21 harshil21 harshil21 left review comments

Assignees

No one assigned

Labels

🔌 enhancement pr description: enhancement 📋 pending-reply work status: pending-reply

Projects

None yet

Milestone

v20.0a0

Development

Successfully merging this pull request may close these issues.

3 participants

@kilomeow @Bibo-Joshi @harshil21