Skip to content

Conversation

@abxhr
Copy link
Contributor

@abxhr abxhr commented Oct 2, 2021

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts **_kwargs
  • Added new shortcuts:

    • In Chat & User for all methods that accept chat/user_id
    • In Message for all methods that accept chat_id and message_id
    • For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION
    • Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

Closes #2666

@Bibo-Joshi Bibo-Joshi added the ⚙️ documentation affected functionality: documentation label Oct 2, 2021
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at me having ideas:

abxhr and others added 3 commits October 3, 2021 21:41
@abxhr
Copy link
Contributor Author

abxhr commented Oct 3, 2021

@Poolitzer I have made the requested changes

@Poolitzer
Copy link
Member

cool, looks good to me!

@Poolitzer Poolitzer self-requested a review October 3, 2021 17:56
@Bibo-Joshi Bibo-Joshi merged commit bc7c422 into python-telegram-bot:master Oct 3, 2021
@Bibo-Joshi
Copy link
Member

Thanks for the contribution :)

@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
@harshil21 harshil21 added the hacktoberfest-accepted other: hacktoberfest-accepted label Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ documentation affected functionality: documentation hacktoberfest-accepted other: hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert issue & PR templates to forms (already taken)

4 participants