Include max_connections in start_webhook #2547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi. Thanks for the PR! I took the liberty to update the docs & add a test case so that we can include this in the upcoming release :) |
Contributor
Author
|
Thanks! |
Member
|
Test failures are due to codecov not being able to upload the coverage reports for some reason … I'll merge anyway, as coverage should be fine :) |
This was referenced Jun 6, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was earlier possible to set max_connections using the set_webhook method. With the
max_connectionsargs tostart_webhookmethodmax_connectionsto user set value