Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

Does three things:

  1. adds ChatMemberUpdated.difference as suggested by @harshil21 - the naming of the method is up for discussion, if you have other suggestions :)
  2. Adds new constants to tg.constants/Update which can be used to set allowed_updates more conveniently
  3. adds an example on how to use ChatMemberHandler and above stuff

pre-commit/pylint is failing locally for some reason. let's see how CI behaves.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)

If the PR contains API changes (otherwise, you can delete this passage)

  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION

@Bibo-Joshi Bibo-Joshi added enhancement ⚙️ examples affected functionality: examples labels Apr 27, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Found mostly spelling errors.

Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, I love the example and difference is a great idea.

Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Bibo-Joshi Bibo-Joshi merged commit 3938a57 into master Apr 30, 2021
@Bibo-Joshi Bibo-Joshi deleted the chat-member-updates branch April 30, 2021 08:14
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2021
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 enhancement pr description: enhancement ⚙️ examples affected functionality: examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants