Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found out by accident that
chatAction.upload/record_audiohas been replaced byvoicesomewhere between 11/2020 and 12/2020. Kudos @RenshouSorinozuka for making me find this :Dthe audio-things still work because of this: https://github.com/tdlib/telegram-bot-api/blob/bf371b21b97c4c8d0b2e2646db05c654cb05480e/telegram-bot-api/Client.cpp#L4850 but backward compatibility is undocumented. I pinged botsupport asking them to at least document the change/announce somewhere, so I'd wait with mergen a bit to give them a change to update the docs, which we then could properly copy.
Also I didn't find a good way to add a deprecation warning to constants … Maybe someone has an idea? Then again, maybe it's not necessary.
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)If the PR contains API changes (otherwise, you can delete this passage)
If relevant:
telegram.constantsand shortcuts to them as class variablesREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION