Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Mar 6, 2021

Note:

For people stumbling upon this: After releasing this PR in v13.4 we became aware that is was unintentioally breaking. See here for details.


When ready closes #2416

Already tested

  • polling
  • nginx reverse proxy webhooks with letsencrypt (not passing cert to TG) & with self-signed certificate (passing cert to TG)

To be done:

  • test having the built-in Webserver handle the SSL stuff. IISC I can't test that on my lolcal setup, though …
  • double check if docs are updated enough
  • unit tests
  • add dreprecation of clean to Deprecation: v15 #2347

This also

  • deprecated the clean argument in favor of drop_pending_updates as a) that conforms with the TG nomenclature, b) that name is more speaking
  • adds the ip_address parameter of set_webhook to start_webhook (tbh I don't really understand what it's good for, do we need some special casing for that?)

When ready:

  • Update the wiki page on webhooks according to the changes

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (I did that but leaving it as todo here so we double check the version number before merging)

@Bibo-Joshi Bibo-Joshi added enhancement 🛠 refactor change type: refactor labels Mar 6, 2021
@Bibo-Joshi Bibo-Joshi changed the title Get started Improve set_webhook Mar 7, 2021
@Poolitzer
Copy link
Member

test having the built-in Webserver handle the SSL stuff. IISC I can't test that on my lolcal setup, though …

I can, I did, I can confirm it worked.

@Bibo-Joshi Bibo-Joshi added this to the v13.5 milestone Mar 11, 2021
@Bibo-Joshi Bibo-Joshi requested a review from jh0ker March 11, 2021 19:35
@Bibo-Joshi
Copy link
Member Author

On the last run, Codecov didn't show results for some reason, but the PR looks okay in the dashboard.

Copy link
Member

@jh0ker jh0ker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi Bibo-Joshi merged commit aba17cb into master Mar 13, 2021
@Bibo-Joshi Bibo-Joshi deleted the enhance_start_webhook branch March 13, 2021 14:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2021
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 enhancement pr description: enhancement 🛠 refactor change type: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check if we can be smarter about start_webhook

4 participants