Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

See #2338, but I ended up changing more than the docs, so here is a standalone PR

  • I did not list all the different update/handler types, as that's beyond the scope of the docs imho. Also, for the most updates it's rather obvious, which updates are associated with a chat/user/message id and which aren't.
  • Instead I linked the FAQ, which can be more easily extended and also the wiki is the better place for elaborate explanations.
  • Channel posts are ignored, see ConversationHandler breaks when bot is also used in Channels #487. This PR makes it also ignore edited channel posts, for completeness sake. Note that this is not a user facing change, as CH already ignores new posts, and hence a conversation that would be able to handle edited channel posts (i.e. per_user=per_message=False, per_chat=True) can't even be started. Okay, yeah, if all of per_user=per_chat=per_message=False, then a CH can currenlty handle edited channel posts, but if someone uses that, they should overthink their design pattern …

@Bibo-Joshi Bibo-Joshi added bug 🐛 ⚙️ documentation affected functionality: documentation labels Jan 26, 2021
@Bibo-Joshi Bibo-Joshi added this to the v13.2 milestone Jan 26, 2021
@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer January 26, 2021 19:19
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me talking english

Bibo-Joshi and others added 3 commits January 31, 2021 18:34
Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
@Bibo-Joshi Bibo-Joshi merged commit 544a3fb into master Feb 1, 2021
@Bibo-Joshi Bibo-Joshi deleted the ch-updates branch February 1, 2021 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2021
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 bug pr description: bug ⚙️ documentation affected functionality: documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants