You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
Created new or adapted existing unit tests
Added myself alphabetically to AUTHORS.rst (optional)
If the PR contains API changes (otherwise, you can delete this passage)
Added new shortcuts:
In Chat & User for all methods that accept chat/user_id
In Message for all methods that accept chat_id and message_id
For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
If relevant:
Added new constants at telegram.constants and shortcuts to them as class variables
Added new handlers for new update types
Added new filters for new message (sub)types
Added or updated documentation for the changed class(es) and/or method(s)
Update docs in Message to change from update.message to update.effective_message
Fix send_chat_action docs in Chat
Updates in telegram/utils/request.py
mypy was giving the error message unused 'type: ignore' comment, fixed by removing type: ignore in the fileSee updated comment below
pylint was giving the error message E1101: Module 'socket' has no 'TCP_KEEPIDLE' member (no-member), fixed by moving # pylint: disable=no-member to the actual line of code
Update 1
Looks like Codecov and test-pre-commit are complaining after removing type: ignore in request.py, but my local mypy complains if I didn't make those changes and I can't commit. How should we deal with this?
Update 2 - 5ca5fb6
Not sure what went wrong in my first commit, I just tried rolling back the changes with some updates in request.py but this time it went through. Codecov is still complaining though in line 197.
Update 3 - 79e536b
I've reverted all the changes I made related to the error messages that I was getting from mypy, and everything is working fine now. So weird that it was complaining in my first commit.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)If the PR contains API changes (otherwise, you can delete this passage)
Added new shortcuts:
Chat&Userfor all methods that acceptchat/user_idMessagefor all methods that acceptchat_idandmessage_idMessageshortcuts: Addedquoteargument if methods acceptsreply_to_message_idCallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
telegram.constantsand shortcuts to them as class variablesSummary
Message(closes [FEATURE] Shortcuts for Message #2322)reply_chat_actionreply_gamereply_invoiceMessageto change fromupdate.messagetoupdate.effective_messagesend_chat_actiondocs inChattelegram/utils/request.pymypywas giving the error messageunused 'type: ignore' comment, fixed by removingtype: ignorein the filepylintwas giving the error messageE1101: Module 'socket' has no 'TCP_KEEPIDLE' member (no-member), fixed by moving# pylint: disable=no-memberto the actual line of code