Improve typing & docs of handlers #2243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poolitzer
requested changes
Dec 16, 2020
Member
Poolitzer
left a comment
There was a problem hiding this comment.
left a comment here and there
Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2242
I made
Handlerbe a generic class, this allows us to use the "update type" consistently in the annotation of the callback and the methods. Also updated the docs a bit.@revolter maybe you can install this branch via
pip install git+https://github.com/python-telegram-bot/python-telegram-bot.git@fix-2242and check if it acutally works for you?