Skip to content

Use f-strings where possible #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 1 commit into from
Nov 23, 2020
Merged

Use f-strings where possible #2222

Bibo-Joshi merged 1 commit into from
Nov 23, 2020

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Nov 23, 2020

closes #2124

github-actions[bot]
github-actions bot reviewed Nov 23, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

@tsnoam Telegram GithubBot Revised
Copy link
Member

tsnoam commented Nov 23, 2020

@Bibo-Joshi LGTM

Looked on the telegram folder only (not examples or tests)

@Bibo-Joshi Bibo-Joshi merged commit 58b9882 into master Nov 23, 2020
@Bibo-Joshi Bibo-Joshi deleted the f-strings branch November 23, 2020 21:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] change our format to f-strings

3 participants

@Bibo-Joshi @tsnoam