Skip to content

Correct some type hints #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 4 commits into from
Nov 29, 2020
Merged

Correct some type hints #2204

Bibo-Joshi merged 4 commits into from
Nov 29, 2020

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Nov 10, 2020

closes #2191

we can gather more corrections here and merge before releasing

@Bibo-Joshi Bibo-Joshi added the ⚙️ bot-api affected functionality: bot-api label Nov 10, 2020
@Bibo-Joshi Bibo-Joshi added this to the 13.1 milestone Nov 10, 2020
@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer November 10, 2020 19:47
@Bibo-Joshi Bibo-Joshi added ⚙️ type-hinting affected functionality: type-hinting and removed ⚙️ bot-api affected functionality: bot-api labels Nov 10, 2020
Poolitzer
Poolitzer approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG so far

@Bibo-Joshi Bibo-Joshi mentioned this pull request Nov 18, 2020
Closed
Poolitzer
Poolitzer approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi
Merge branch 'master' into type-hinting
f1a6f26 
# Conflicts:
#	telegram/bot.py
#	telegram/utils/helpers.py
@Bibo-Joshi Bibo-Joshi merged commit d27d1ea into master Nov 29, 2020
@Bibo-Joshi Bibo-Joshi deleted the type-hinting branch November 29, 2020 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Poolitzer Poolitzer Poolitzer approved these changes

Assignees

No one assigned

Labels

⚙️ type-hinting affected functionality: type-hinting

Projects

None yet

Milestone

13.1

Development

Successfully merging this pull request may close these issues.

[BUG] Type Hinting of reply_markups

3 participants

@Bibo-Joshi @Poolitzer