Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

should close #2166

@Bibo-Joshi Bibo-Joshi added the ⚙️ type-hinting affected functionality: type-hinting label Oct 31, 2020
@letmejustputthishere
Copy link

letmejustputthishere commented Oct 31, 2020

I removed the telegram/py.typed I added before to overcome this issue and uninstalled the previous python-telegram-bot version. After installing the pep561 branch, the same error occurs again. This doesn't solve the problem for me.

I don't know if it's worth mentioning: I'm using poetry as a package manager.

@Bibo-Joshi
Copy link
Member Author

Okay … I'll look into it :)

@Bibo-Joshi
Copy link
Member Author

py.typed was just in the wrong dir. I've checked that python setup.py sdist bdist_wheel includes telegram/py.typed both in the wheel and in the .tar.gz and installing from this branch also worked. @letmejustputthishere could you double check on your end by installing from this branch?

@letmejustputthishere
Copy link

It works like a charm, thanks a lot!

@Bibo-Joshi Bibo-Joshi merged commit 8e7c0d6 into master Nov 1, 2020
@Bibo-Joshi Bibo-Joshi deleted the pep561 branch November 1, 2020 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ type-hinting affected functionality: type-hinting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mypy doesn't pick up type hints[BUG]

3 participants