Tighten pre commit #2131
Merged
Tighten pre commit #2131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # telegram/chat.py # telegram/chatmember.py # telegram/dice.py # telegram/files/sticker.py # telegram/messageentity.py # telegram/poll.py
# Conflicts: # examples/timerbot.py # telegram/chat.py # telegram/chatmember.py # telegram/dice.py # telegram/ext/basepersistence.py # telegram/ext/conversationhandler.py # telegram/files/sticker.py # telegram/message.py # telegram/messageentity.py # telegram/poll.py
# Conflicts: # telegram/user.py # tests/test_conversationhandler.py
# Conflicts: # telegram/ext/filters.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently switched to Black formatting to increase code quality and I thought it would be good to also tighten the other precommit hooks. This PR
TBH the result turned out to be not as great as I had hoped :D Most of the pylint complains that arose I simply disabled either on that very line, some on module level and a bunch globally. I did some improvements like
elifsafterreturnsIMO this PR still helps improve code quality as it
# pylint: disable=comments. Currently you just don't know that there are warnings.But of course the benefit is not arbitrarily high, so I'd be okay with closing if the the other devs don't see the value of this PR :)