Skip to content

Fixed few type hints #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 5 commits into from
Oct 9, 2020
Merged

Fixed few type hints #2118

Bibo-Joshi merged 5 commits into from
Oct 9, 2020

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Oct 8, 2020

No description provided.

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Oct 8, 2020

Upsie, that should only be str. ChatAction just provides the correct strings as class attributes … Could you change that and also check the other occurrences?

@Bibo-Joshi Bibo-Joshi added the ⚙️ type-hinting affected functionality: type-hinting label Oct 8, 2020
@harshil21
Copy link
Member Author

harshil21 commented Oct 8, 2020

Upsie, that should only be str. ChatAction just provides the correct strings as class attributes … Could you change that and also check the other occurrences?

Oh alright. Just fixed another type hint in send_message()

@harshil21 harshil21 changed the title Add str type hint to bot.send_chat_action() Fixed few type hints Oct 8, 2020
@Bibo-Joshi Bibo-Joshi merged commit 83a8874 into python-telegram-bot:master Oct 9, 2020
@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Oct 9, 2020

Thanks for the contribution :)

@harshil21 harshil21 deleted the patch-1 branch October 9, 2020 06:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

⚙️ type-hinting affected functionality: type-hinting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harshil21 @Bibo-Joshi