Skip to content

Add Py3.8 to docs #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tsnoam merged 2 commits into from
Mar 11, 2020
Merged

Add Py3.8 to docs #1824

tsnoam merged 2 commits into from
Mar 11, 2020

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Mar 10, 2020

The README already says python 3.5+, so we're good there.
Added py38 to setup.py
If I understand correctly, the pypi badge will state py3.8 as soon as we release with the new setup.py

@Poolitzer, do we need to do something with the pytest yml?

matrix:
  python-version: [3.5, 3.6, 3.7, 3.8]
  os: [ubuntu-latest, windows-latest]
  include:
    - os: ubuntu-latest
      python-version: 3.7
      test-build: True
    - os: windows-latest
      python-version: 3.7
      test-build: True

@Poolitzer
Copy link
Member

Poolitzer commented Mar 10, 2020

it already has 3.8 what more do you want? ;P

@Bibo-Joshi
Copy link
Member Author

Bibo-Joshi commented Mar 10, 2020

No, I mean the include: ... part

tsnoam
tsnoam requested changes Mar 10, 2020
View reviewed changes
@Poolitzer
Copy link
Member

Poolitzer commented Mar 11, 2020 •
edited
Loading

Okay, no, the include part is for running the build test, which I think just tests if it builds correctly, which is enough if we do it once per platform, doesnt really matter which version its on.

python-telegram-bot/tests/test_meta.py

Lines 37 to 39 in 43bfebb

@pytest.mark.skipif(not os.getenv('TEST_BUILD', False), reason='TEST_BUILD not enabled')
def test_build():
assert os.system('python setup.py bdist_dumb') == 0 # pragma: no cover
this is the test itself, if you want to check it out

@tsnoam tsnoam merged commit eac7f02 into master Mar 11, 2020
@tsnoam tsnoam deleted the py38 branch March 11, 2020 21:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tsnoam tsnoam tsnoam requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Bibo-Joshi @Poolitzer @tsnoam