Skip to content

updating pre-commit config file #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tsnoam merged 1 commit into from
Feb 21, 2020
Merged

updating pre-commit config file #1787

tsnoam merged 1 commit into from
Feb 21, 2020

Conversation

@Poolitzer
Copy link
Member

@Poolitzer Poolitzer commented Feb 20, 2020 •
edited
Loading

as discussed in the chat

I changed sha to rev (which is the way to go) and also changed the deprecated url from flake8 to the official one. I picked 3.7.1 because thats the version we took from the old collection

@Poolitzer Poolitzer requested a review from tsnoam February 20, 2020 23:32
@tsnoam Telegram GithubBot Revised
Copy link
Member

tsnoam commented Feb 21, 2020

@Poolitzer Have you tested it on a clean clone?
If you have, we can merge.

@Poolitzer
Copy link
Member Author

Poolitzer commented Feb 21, 2020

I did a reinstall... Is that enough? ;p

@tsnoam tsnoam merged commit 14f712b into master Feb 21, 2020
@tsnoam tsnoam deleted the pre_commit_update branch February 21, 2020 05:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tsnoam tsnoam Awaiting requested review from tsnoam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Poolitzer @tsnoam