added link property to bot #1770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link property was available in User and Chat objects but not in Bot which was inconsistent.
Bot will always have username so it does not require hasattr check
Bibo-Joshi
requested changes
Feb 9, 2020
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Hi. Thanks for the PR. I think it's a good addition. However, we will need a test for the new property. Could you add that?
Member
|
@ak4zh Are you still interested in this? If yes, could you add tests? |
Member
|
CI fail unrelated ( |
Member
|
@ak4zh thank you for the contribution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link property was available in User and Chat objects but not in Bot which was inconsistent.