Skip to content

Log datetimes correctly #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tsnoam merged 1 commit into from
Jan 26, 2020
Merged

Log datetimes correctly #1714

tsnoam merged 1 commit into from
Jan 26, 2020

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Jan 19, 2020

When time_spec is a datetime.datetime, %f will fail …

@Bibo-Joshi Bibo-Joshi added this to the 12.4 milestone Jan 19, 2020
@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer January 19, 2020 09:41
Poolitzer
Poolitzer approved these changes Jan 19, 2020
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks lovely!

@tsnoam tsnoam merged commit 0df526d into master Jan 26, 2020
@tsnoam tsnoam deleted the jobqueue-logging branch January 26, 2020 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Poolitzer Poolitzer Poolitzer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

12.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Bibo-Joshi @Poolitzer @tsnoam