Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Nov 23, 2019

Closes #1507
I hope this is what you meant, @Eldinnie ?

@Bibo-Joshi Bibo-Joshi added the 📋 pending-review work status: pending-review label Nov 23, 2019
@Bibo-Joshi Bibo-Joshi added this to the 12.5 milestone Nov 23, 2019
@Bibo-Joshi Bibo-Joshi requested a review from Eldinnie November 23, 2019 11:06
@Eldinnie
Copy link
Member

It is exactly what I meant, but looking at it, I think we should maybe make the command and prefix attributes setable attributes in such a way that _commands will be recreated when they're set. What do you think?

@Bibo-Joshi
Copy link
Member Author

While I don't think that this will be needed very often, it sure makes it safer. Will do.

Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid changes. LGTM

@Bibo-Joshi Bibo-Joshi merged commit e9cb667 into master Mar 30, 2020
@Bibo-Joshi Bibo-Joshi deleted the fix-1507 branch March 30, 2020 15:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

📋 pending-review work status: pending-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rename Prefixhandlers internally constructed list to _commands

4 participants