Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Nov 23, 2019

Closes #1601.
Turns out only switch_inline_quer(_current_chat) can reasonably be an empty string. All other optionals should be either None or a non-empty string.

@Bibo-Joshi Bibo-Joshi added the ⚙️ tests affected functionality: tests label Nov 23, 2019
@Bibo-Joshi Bibo-Joshi added this to the 12.5 milestone Nov 23, 2019
@Bibo-Joshi Bibo-Joshi added the 📋 pending-review work status: pending-review label Nov 23, 2019
@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer March 9, 2020 18:53
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper test, looks good.

@Bibo-Joshi Bibo-Joshi merged commit 61a66a3 into master Mar 30, 2020
@Bibo-Joshi Bibo-Joshi deleted the empty_string_tests branch March 30, 2020 22:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

📋 pending-review work status: pending-review ⚙️ tests affected functionality: tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for optional parameters that should accept empty string as input

3 participants