Skip to content

Conversation

@clonex10100
Copy link
Contributor

@clonex10100 clonex10100 commented Oct 1, 2019

Closes #1519

Copy link
Member

tsnoam commented Oct 1, 2019

@clonex10100 1. We have a very fragile logic with username/first name/last name when it comes to user details.
We should make sure it's either consistent or the difference makes sense.

  1. Unitests seems to fail due to (what I think is) a change in the shell scripting behaviour of Travis. The if... then... logic should be modified to have else true (this is very common behaviour with Makefile)

@Poolitzer
Copy link
Member

Poolitzer commented Oct 10, 2019

Hey @tsnoam , what do you mean?

  1. The bots first name should be the bots first name. Its always given, it should be correctly returned in the to_dict function.

  2. Unitest should not fail because of this change. If there is actually an issue in the file, we should move it to a separate issue and PR, but this one is fine imo

The only issue I see is that the branch isn't named properly and OP didnt add themself to the author file :)

@Poolitzer Poolitzer added this to the 12.2 milestone Oct 10, 2019
@Poolitzer Poolitzer added the 📋 pending-merge work status: pending-merge label Oct 10, 2019
@tsnoam
Copy link
Member

tsnoam commented Oct 11, 2019

@Poolitzer
I would expect test_get_me_and_properties() to fail after this change.
I need to understand why it didn't fail before or why it doesn't fail now.

@tsnoam
Copy link
Member

tsnoam commented Oct 11, 2019

uh. of course. we need a new test for to_dict

Copy link
Member

@tsnoam because that is not affected by to_dict right? They are only using de_json

@tsnoam tsnoam merged commit 2cc9aac into python-telegram-bot:master Oct 11, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

📋 pending-merge work status: pending-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bot dict return wrong value for first_name

3 participants