Skip to content

Conversation

@Tom-Brouwer
Copy link

Several warnings for the conversationhandler were logged to the root logger (logging.logger), instead of the module level logger (self.logger)

@jsmnbom
Copy link
Member

jsmnbom commented Dec 28, 2018

I wonder if we shouldn't really be using warnings.warn for these cases.
Per the python docs:

warnings.warn() in library code if the issue is avoidable and the client application should be modified to eliminate the warning
logging.warning() if there is nothing the client application can do about the situation, but the event should still be noted

@jsmnbom jsmnbom added the 📋 pending-reply work status: pending-reply label Jan 4, 2019
@Eldinnie
Copy link
Member

Eldinnie commented Feb 13, 2019

I think warnings.warn is appropriate here. Also please merge from master, because these warnings have a live change.

@jsmnbom
Copy link
Member

jsmnbom commented Feb 13, 2019

This has been superseeded #1343. Thanks a lot for the PR @Tom-Brouwer, your commit also exists in that PR, we must wanted to make a couple of commits on top.

@jsmnbom jsmnbom closed this Feb 13, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

📋 pending-reply work status: pending-reply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants