Update data.py to be compatible with example #1213
Conversation
for now, if you process personal_info with example code, then you got an error if there is no set option to get native fist and last name. setting default value will allow to process personal_info without native name/surname transation
|
Thanks a lot for the PR @reablaz. You are indeed correct that the native arguments should be optional. It seems like you didn't quite set up the development environment as described in .github/CONTRIBUTING.rst. Most specifically the pre-commit-hook flake8, which is complaining that Could we perhaps get you to fix that line? :D |
|
You still with us @reablaz ? :D |
i hope i understood right this. sorry for delay, just starting using github!
|
Hi there! I shortened this line, thank you for your pointing! |
|
failed again.. can anyone teach me how to do things right? :D |
|
Actually it seems the build failed for other reasons, so this looks good :D Would you like to add yourself to AUTHORS.rst, please do so :) Otherwise just reply and we'll get this merged :D |
|
Hey there! I think my contribution is too trivial to add myself to authors list. So we can skip this step. Let's merge 👍 |
|
Alright, thanks once again :D |
for now, if you process personal_info with example code, then you got an error if there is no set option to get native fist and last name.
setting default value will allow to process personal_info without native name/surname transation