Skip to content

[BUG] refresh_*_data can overwrite *_data before the actual values are saved. #3554

@rejedai

Description

@rejedai

Steps to Reproduce

  1. Implement the refresh_user_data/refresh_chat_data/refresh_bot_data method of BasePersistence class.
    2.Save something to user_data/chat_data/bot_data

Expected behaviour

refresh_user_data/refresh_chat_data/refresh_bot_data should be called strictly after the data is updated.

Actual behaviour

refresh_user_data/refresh_chat_data/refresh_bot_data can override actual data

Operating System

Linux

Version of Python, python-telegram-bot & dependencies

python-telegram-bot 20.1
Bot API 6.5
Python 3.10.9 (main, Dec 19 2022, 17:35:49) [GCC 12.2.0]

Relevant log output

No response

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions