V20 updates #47
Merged
V20 updates #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ptbcontrib/reply_to_message_filter/requirements.txt
Member
|
I already did the code upgrade for the API wrapper, not the tests yet though. It is in the public branch. |
Member
Author
|
@Poolitzer Thanks for the heads up 👍 |
Member
|
@Bibo-Joshi I opened #48 for the wrapper, have a look. |
# Conflicts: # ptbcontrib/roles/__init__.py # ptbcontrib/roles/roles.py # ptbcontrib/roles/roleshandler.py # requirements-dev.txt # run_tests.py # setup.cfg # tests/conftest.py # tests/test_get_chat_link.py # tests/test_reply_to_message_filter.py # tests/test_roles.py # tests/test_send_by_kwargs.py
Member
Author
|
Don't understand why the tests started to fail after mergin #46. WIll try to investigate sometime later |
* Update Prostgres Persistence * Fix conversations & Drop unused function
Member
Author
|
upgrading the jobstore contribution is not yet included in this PR, but I guess we don't have to wait for that - and rather not forget about this PR :D @harshil21 @Poolitzer if one of you could give the changes a rough second look, that would be awesome :) |
harshil21
reviewed
May 31, 2022
harshil21
approved these changes
Jun 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so far:
ReplyToMessageFiltersend_by_kwargs#39)Roles.chat_admins/ownerthingies, which made api requests in thecheck_update(rather:filter) step. Don't know why I even thought that were a good idea …Based on #46. Selected that branch as target so that it's easier to see the changes. Should be merged into baster once #46 is merged.